Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: drop publish, publishReplay, and ConnectableObservable #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

refactor: drop publish, publishReplay, and ConnectableObservable #1638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5187d63
refactor: drop `publish`, `publishReplay`, and `ConnectableObservable`
edbzn Nov 6, 2023
967046a
refactor: drop deprecated `tap` overload
edbzn Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: drop deprecated tap overload
  • Loading branch information
@edbzn @hoebbelsB
edbzn authored and hoebbelsB committed May 13, 2024
commit 967046a44788f92806b018f6bb8871b8bcc4850b
8 changes: 4 additions & 4 deletions 8 apps/demos/src/app/rx-angular-pocs/cdk/utils/rxjs/observable/stateful-observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ export function createAccumulationObservable<T extends object>(
(state, [slice, stateAccumulator]) => stateAccumulator(state, slice),
{} as T
),
tap(
(newState) => (compositionObservable.state = newState),
(error) => console.error(error)
),
tap({
next: (newState) => (compositionObservable.state = newState),
error: (error) => console.error(error),
}),
catchError((e) => EMPTY)
),
{
Expand Down
8 changes: 4 additions & 4 deletions 8 libs/state/selections/src/lib/accumulation-observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ export function createAccumulationObservable<T extends object>(
(state, [slice, stateAccumulator]) => stateAccumulator(state, slice),
{} as T
),
tap(
(newState) => (compositionObservable.state = newState),
(error) => console.error(error)
),
tap({
next: (newState) => (compositionObservable.state = newState),
error: (error) => console.error(error),
}),
catchError((e) => EMPTY)
),
{
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.