refactor: drop publish, publishReplay, and ConnectableObservable
#1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbzn
commented
Nov 6, 2023
hoebbelsB
reviewed
Nov 11, 2023
| @@ -74,7 +74,7 @@ export class RxEffects implements OnDestroy, OnDestroy$ { | ||
| private static nextId = 0; | ||
| readonly _hooks$ = new Subject<DestroyProp>(); | ||
| private readonly observables$ = new Subject<Observable<unknown>>(); | ||
| // we have to use publish here to make it hot (composition happens without subscriber) | ||
| // we have to use share here to make it hot (composition happens without subscriber) |
There was a problem hiding this comment.
no, it's not... https://stackblitz.com/edit/rxjs-nwerqp?file=index.ts
There was a problem hiding this comment.
probably it is meant in a different way
There was a problem hiding this comment.
Why it is not true? share will multicast the stream (hot), so the computation is only made once even if there are multiple subscribers. Here is an example.
There was a problem hiding this comment.
composition happens without subscriber is not true for share, only for connectable after calling the connect method :)
hoebbelsB
reviewed
Nov 11, 2023
|
TODO: check RxJS version compatibility |
|
@edbzn this def. changes our minimum rxjs requirement.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish,publishReplay, andConnectableObservableare deprecated in RxJS v7 and removed in upcoming v8.