Fix invalid suggestion for parenthesized break#156443
Merged
Merged
Fix invalid suggestion for parenthesized break#156443
Conversation
Collaborator
|
rustbot has assigned @ShoyuVanilla. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ShoyuVanilla
approved these changes
May 18, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
May 18, 2026
…uwer Rollup of 13 pull requests Successful merges: - #156709 (stdarch subtree update) - #155006 (stabilize `feature(cfg_target_has_atomic_equal_alignment)`) - #156444 (Implement `OsStr::split_at`) - #156582 (Allow `global_asm!` in statement positions) - #156661 (Remove `UncheckedIterator`) - #152367 (Derives `Copy` for `ffi::FromBytesUntilNulError`) - #156443 (Fix invalid suggestion for parenthesized break) - #156606 (Add pext/pdep as aliases for extract_bits/deposit_bits) - #156630 (Replace `println!` with `assert!` in HashMap documentation examples) - #156644 (Widen the result of `widening_mul`.) - #156653 (Update `sysinfo` version to `0.39.2`) - #156697 (Add diagnostic items for IoBufReader and StdinLock) - #156704 (reduce usage of `box_patterns` in tests)
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Jun 8, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#156709 (stdarch subtree update) - rust-lang/rust#155006 (stabilize `feature(cfg_target_has_atomic_equal_alignment)`) - rust-lang/rust#156444 (Implement `OsStr::split_at`) - rust-lang/rust#156582 (Allow `global_asm!` in statement positions) - rust-lang/rust#156661 (Remove `UncheckedIterator`) - rust-lang/rust#152367 (Derives `Copy` for `ffi::FromBytesUntilNulError`) - rust-lang/rust#156443 (Fix invalid suggestion for parenthesized break) - rust-lang/rust#156606 (Add pext/pdep as aliases for extract_bits/deposit_bits) - rust-lang/rust#156630 (Replace `println!` with `assert!` in HashMap documentation examples) - rust-lang/rust#156644 (Widen the result of `widening_mul`.) - rust-lang/rust#156653 (Update `sysinfo` version to `0.39.2`) - rust-lang/rust#156697 (Add diagnostic items for IoBufReader and StdinLock) - rust-lang/rust#156704 (reduce usage of `box_patterns` in tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156383
The old code incorrectly assumed
e.spanstarted exactly at the beginning ofbreak. Fixed by locating the exact start position ofbreak.