borrowck: Apply user_arg_index nomenclature more broadly#154895
Merged
Merged
borrowck: Apply user_arg_index nomenclature more broadly#154895
user_arg_index nomenclature more broadly#154895Conversation
No change in behavior. Only renames and a couple of added comments.
| /// as the name suggests. =) | ||
| /// | ||
| /// N.B., in the case of a closure, index 0 is the implicit self parameter, | ||
| /// and not the first input as seen by the user. |
Contributor
There was a problem hiding this comment.
is this also true for #[track_caller] parameters? might be nice to document all the cases.
Member
Author
There was a problem hiding this comment.
Good call. After browsing around the compiler code a bit, my impression is that #[track_caller] adds an argument to the ABI, but not to MIR. See in particular this:
rust/compiler/rustc_codegen_ssa/src/mir/block.rs
Lines 1319 to 1323 in c9d3a00
So AFAIK the added comment remains accurate.
@rustbot ready
jdonszelmann
requested changes
Apr 10, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…uwer Rollup of 11 pull requests Successful merges: - #154654 (Move `std::io::ErrorKind` to `core::io`) - #145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - #154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - #155213 (resolve: Make sure visibilities of import declarations make sense) - #155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - #155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - #155549 (Remove some unnecessary lifetimes.) - #154248 (resolve : mark repr_simd as internal) - #154772 (slightly optimize the `non-camel-case-types` lint) - #155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - #155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
rust-timer
added a commit
that referenced
this pull request
Apr 20, 2026
Rollup merge of #154895 - Enselic:user-arg-index, r=jdonszelmann borrowck: Apply `user_arg_index` nomenclature more broadly No change in behavior. Only renames and a couple of added comments. As requested here: #154674 (comment) r? jdonszelmann
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 21, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#154654 (Move `std::io::ErrorKind` to `core::io`) - rust-lang/rust#145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - rust-lang/rust#154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - rust-lang/rust#155213 (resolve: Make sure visibilities of import declarations make sense) - rust-lang/rust#155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - rust-lang/rust#155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - rust-lang/rust#155549 (Remove some unnecessary lifetimes.) - rust-lang/rust#154248 (resolve : mark repr_simd as internal) - rust-lang/rust#154772 (slightly optimize the `non-camel-case-types` lint) - rust-lang/rust#155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - rust-lang/rust#155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change in behavior. Only renames and a couple of added comments.
As requested here: #154674 (comment)
r? jdonszelmann