-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 9 pull requests #141954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #141954
Conversation
fix: Recognize salsa cycles in `thread_result_to_response`
fix: Fix import insertion not being fully cfg aware
…efs-constructor-search docs: add documentation for find_all_refs constructor search
internal: Restructure some semantics APIs for virtual macro files
refactor: Remove unncessary duplication in highlight_related
Account for `Generate` actions when filtering the allowed ones
fix: Fix manual not containing diagnostics documentation
…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772
This helps with efforts to deduplicate the `MutVisitor` and the `Visitor` code. All users of `Visitor`'s methods that have extra `NodeId` as parameters really just want to visit the id on its own. Also includes some methods deduplicated and cleaned up as a result of this change.
This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior.
This disables the f64 minimum/maximum tests for the arm-unknown-linux-gnueabihf job. The next release will be supporting cross-compiled doctests, and these tests fail on that platform. It looks like this was just fixed via llvm/llvm-project#142170, but I assume that will not trickle down to our copy of llvm in the next couple of weeks. Assuming that does get fixed when llvm is updated, then these can be removed. cc rust-lang#141087
Obviously `test-float-parse` is a tool like any other in `src/tools`. Signed-off-by: onur-ozkan <work@onurozkan.dev>
…tter, r=bjorn3 Improve documentation for codegen options This adds more information to many different codegen options. It should not add any new guarantees, just document existing behavior. r? bjorn3
…-compiling, r=cuviper rustc_llvm: add Windows system libs only when cross-compiling from Wi… …ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772 Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)
…t_id, r=oli-obk Add `visit_id` to ast `Visitor` This helps with efforts to deduplicate the `MutVisitor` and the `Visitor` code. All users of `Visitor`'s methods that have extra `NodeId` as parameters really just want to visit the id on its own. Also includes some methods deduplicated and cleaned up as a result of this change. r? oli-obk
Enable triagebot `[concern]` functionality Documentation at: https://forge.rust-lang.org/triagebot/concern.html Example at: rust-lang/triagebot#2024 r? Kobzol
…ling, r=oli-obk Decouple "reporting in deps" from `FutureIncompatibilityReason` The reason should just be it -- the reason. It never felt right to me that it was also responsible for whatever we include the warning in cargo's reports. It gets especially unruly if you want to add non-`FutureReleaseError*` warnings which are included in the reports. I just added a field to `FutureIncompatibleInfo` to control whatever the diagnostic is included in the cargo's reports.
…r=Kobzol move `test-float-parse` tool into `src/tools` dir Obviously `test-float-parse` is a tool like any other in `src/tools`. cc `@tgross35`
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: c68032fd4c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c68032f (parent) -> 2f17612 (this PR) Test differencesShow 278 test diffs278 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 2f176126aaf3fd316fc5ced3d9a111a48797b52c --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (2f17612): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 2.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 743.521s -> 744.283s (0.10%) |
Successful merges:
visit_id
to astVisitor
#141843 (Addvisit_id
to astVisitor
)rust-analyzer
#141881 (Subtree update ofrust-analyzer
)[concern]
functionality #141930 (Enable triagebot[concern]
functionality)FutureIncompatibilityReason
#141936 (Decouple "reporting in deps" fromFutureIncompatibilityReason
)test-float-parse
tool intosrc/tools
dir #141949 (movetest-float-parse
tool intosrc/tools
dir)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup