Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Report never type lints in dependencies #141937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

Report never type lints in dependencies #141937

wants to merge 1 commit into from
+647 −0

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Jun 2, 2025 •
edited by rustbot
Loading

This PR marks never type lints (never_type_fallback_flowing_into_unsafe & dependency_on_unit_never_type_fallback) to be included in cargo's reports / to be emitted when they happen in dependencies.

This PR is based on #141936
r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@traviscross traviscross added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@traviscross
Copy link
Contributor

traviscross commented Jun 3, 2025 •
edited
Loading

In advance of the Rust 2024 edition, we made a plan for later stabilizing the never type (via FCP in #123508).

The plan went like this:

  1. Change fallback to ! in Rust 2024.
  2. Stabilize Rust 2024.
  3. At a later date when 2024 edition adoption is widespread:
    • Make the breaking change to fall back to ! always everywhere.
    • Change Infallible = !.
    • Stabilize ! (!).

These FCWs have been out there a long time now -- since Rust 1.80. The edition has been out since Rust 1.85. I propose that we take the next step and extend the FCWs to lint in dependencies in preparation for next taking the final step to change fallback in all editions and stabilize the never type.

@rfcbot fcp merge

Tracking:

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 3, 2025 •
edited
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 3, 2025
@traviscross traviscross added I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Jun 3, 2025
@traviscross
Copy link
Contributor

Big thanks to @WaffleLapkin for pushing this forward.

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

☔ The latest upstream changes (presumably #141954) made this pull request unmergeable. Please resolve the merge conflicts.

@WaffleLapkin WaffleLapkin force-pushed the never-report-in-deps branch from dd912ec to 851129f Compare June 3, 2025 18:02
oli-obk
oli-obk approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with FCP finished

@scottmcm
Copy link
Member

scottmcm commented Jun 4, 2025

Makes sense to me! Always happy to see progress on ! 🙂

@rfcbot reviewed

@tmandry
Copy link
Member

tmandry commented Jun 4, 2025

@rfcbot reviewed

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 4, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 4, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 4, 2025
@traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Jun 4, 2025
@traviscross traviscross mentioned this pull request Jun 4, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-lang Relevant to the language team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@WaffleLapkin @traviscross @rfcbot @bors @scottmcm @tmandry @oli-obk @rustbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.