Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "GitHub fast path uses http_async"#16861

Merged
weihanglo merged 1 commit into
masterrust-lang/cargo:masterfrom
revert-16847-async/gh-fast-pathrust-lang/cargo:revert-16847-async/gh-fast-pathCopy head branch name to clipboard
Apr 9, 2026
Merged

Revert "GitHub fast path uses http_async"#16861
weihanglo merged 1 commit into
masterrust-lang/cargo:masterfrom
revert-16847-async/gh-fast-pathrust-lang/cargo:revert-16847-async/gh-fast-pathCopy head branch name to clipboard

Conversation

@arlosi

@arlosi arlosi commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Reverts #16847

Fixes #16860

Reverting seems like the easiest way to quickly resolve the issue while we figure out a solution.

@rustbot rustbot added A-git Area: anything dealing with git S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
@rustbot

rustbot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@weihanglo
weihanglo added this pull request to the merge queue Apr 9, 2026
@weihanglo

Copy link
Copy Markdown
Member

I thought only tokio has this restriction 😓

Merged via the queue into master with commit eb94155 Apr 9, 2026
29 checks passed
@weihanglo
weihanglo deleted the revert-16847-async/gh-fast-path branch April 9, 2026 13:44
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Update cargo submodule

5 commits in 101549dddbd2b08e806f50154e3aa4cb3374cc21..eb94155a9a60943bd7b1cb04abec42f5d0de6ddc
2026-04-08 12:51:20 +0000 to 2026-04-09 13:10:20 +0000
- Revert "GitHub fast path uses `http_async`" (rust-lang/cargo#16861)
- Correct spelling in cargo info man page (rust-lang/cargo#16863)
- chore: Update annotate-snippets to 0.12.15 (rust-lang/cargo#16859)
- fix(test): strip RUSTUP_TOOLCHAIN_SOURCE from test environment (rust-lang/cargo#16857)
- Support target.'cfg(..)'.rustdocflags analogously to rustflags (rust-lang/cargo#16846)

r? ghost
github-merge-queue Bot pushed a commit that referenced this pull request Apr 9, 2026
### What does this PR try to resolve?

Add regression test for #16860

### How to test and review this PR?

To locally test, un-revert #16861 and see that it panics.
@rustbot rustbot modified the milestone: 1.96.0 Apr 9, 2026
rust-timer added a commit to rust-lang/rust that referenced this pull request Apr 9, 2026
Rollup merge of #155042 - weihanglo:update-cargo, r=weihanglo

Update cargo submodule

5 commits in 101549dddbd2b08e806f50154e3aa4cb3374cc21..eb94155a9a60943bd7b1cb04abec42f5d0de6ddc
2026-04-08 12:51:20 +0000 to 2026-04-09 13:10:20 +0000
- Revert "GitHub fast path uses `http_async`" (rust-lang/cargo#16861)
- Correct spelling in cargo info man page (rust-lang/cargo#16863)
- chore: Update annotate-snippets to 0.12.15 (rust-lang/cargo#16859)
- fix(test): strip RUSTUP_TOOLCHAIN_SOURCE from test environment (rust-lang/cargo#16857)
- Support target.'cfg(..)'.rustdocflags analogously to rustflags (rust-lang/cargo#16846)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-git Area: anything dealing with git

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub fast path causes panic due to async executor nesting

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.