plotly crosstalk experiments - #346
#346Open
cpsievert wants to merge 10 commits into
rstudio:mainrstudio/leaflet:mainfrom
cpsievert:carson/feature/plotlycpsievert/leaflet:carson/feature/plotlyCopy head branch name to clipboard
Open
plotly crosstalk experiments#346cpsievert wants to merge 10 commits intorstudio:mainrstudio/leaflet:mainfrom cpsievert:carson/feature/plotlycpsievert/leaflet:carson/feature/plotlyCopy head branch name to clipboard
cpsievert wants to merge 10 commits into
rstudio:mainrstudio/leaflet:mainfrom
cpsievert:carson/feature/plotlycpsievert/leaflet:carson/feature/plotlyCopy head branch name to clipboard
Conversation
…rt for persistent selection
Member
|
I'm swamped with rstudio::conf prep but look forward to reviewing this later (feel free to ping me after the conference if you want to vchat or whatever about this) |
|
|
|
Hello, I have found that the version proposed in this pull request works for highlighting data between between plotly and leaflet maps (in dealing with POINT data, though not POLYGON). Is this going to be merged into the main rstudio/leaflet branch? If not, what needs to happen to get this done? Happy to help if I have enough expertise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues work from #281. The idea is to have leaflet respond to plotly's "advanced" crosstalk selection options (e.g., dynamically altering selection colour and persistent selection)
I'd still consider this PR "experimental" as I'm hoping to add more selection modes (e.g., AND, OR, XOR, COMPLEMENT). I hope to iron out those details before Feb.