Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix key matching algorithm incorrectly not checking all keys if a 0 or a NaN is present #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

rrousselGit
Copy link
Owner

fixes #384

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a3f186) 99.87% compared to head (4782181) 99.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          18       18           
  Lines         810      810           
=======================================
  Hits          809      809           
  Misses          1        1           
Files Coverage Δ
packages/flutter_hooks/lib/src/framework.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrousselGit rrousselGit merged commit 422b2e1 into master Oct 2, 2023
@rrousselGit rrousselGit deleted the fix-384 branch October 2, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] shouldPreserveState may wrongfully preserve state when it shouldn't
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.