rrousselGit
diff --git a/‎packages/flutter_hooks/CHANGELOG.md
Copy file name to clipboardExpand all lines: packages/flutter_hooks/CHANGELOG.md
+4Lines changed: 4 additions & 0 deletions b/‎packages/flutter_hooks/CHANGELOG.md
Copy file name to clipboardExpand all lines: packages/flutter_hooks/CHANGELOG.md
+4Lines changed: 4 additions & 0 deletions
diff --git a/‎packages/flutter_hooks/lib/src/framework.dart
Copy file name to clipboardExpand all lines: packages/flutter_hooks/lib/src/framework.dart
+5-2Lines changed: 5 additions & 2 deletions b/‎packages/flutter_hooks/lib/src/framework.dart
Copy file name to clipboardExpand all lines: packages/flutter_hooks/lib/src/framework.dart
+5-2Lines changed: 5 additions & 2 deletions
diff --git a/‎packages/flutter_hooks/test/use_effect_test.dart
Copy file name to clipboardExpand all lines: packages/flutter_hooks/test/use_effect_test.dart
+46Lines changed: 46 additions & 0 deletions b/‎packages/flutter_hooks/test/use_effect_test.dart
Copy file name to clipboardExpand all lines: packages/flutter_hooks/test/use_effect_test.dart
+46Lines changed: 46 additions & 0 deletions
@@ -1,3 +1,7 @@
+## Unreleased patch
+
+- Fixed key matching algorithm incorrectly not checking all keys if a 0 or a NaN is present (thanks to @AlexDochioiu)
+
 ## 0.20.1 - 2023-08-29
 
 - `useListenableSelector` now supports `null` listeners (thanks to @JWo1F)
 
@@ -183,12 +183,15 @@ Calling them outside of build method leads to an unstable state and is therefore
       if (curr1 is num && curr2 is num) {
         // Checks if both are NaN
         if (curr1.isNaN && curr2.isNaN) {
-          return true;
+          continue;
         }
 
         // Checks if one is 0.0 and the other is -0.0
         if (curr1 == 0 && curr2 == 0) {
-          return curr1.isNegative == curr2.isNegative;
+          if (curr1.isNegative != curr2.isNegative) {
+            return false;
+          }
+          continue;
         }
       }
 
 
@@ -268,6 +268,29 @@ void main() {
     verifyNoMoreInteractions(effect);
   });
 
+  testWidgets(
+      'calls effect when first key is two matching NaN but second key is different',
+      (tester) async {
+    // Regression test for https://github.com/rrousselGit/flutter_hooks/issues/384
+    parameters = [double.nan, 0];
+    await tester.pumpWidget(builder());
+
+    verifyInOrder([
+      effect(),
+      unrelated(),
+    ]);
+    verifyNoMoreInteractions(effect);
+
+    parameters = [double.nan, 1];
+    await tester.pumpWidget(builder());
+
+    verifyInOrder([
+      effect(),
+      unrelated(),
+    ]);
+    verifyNoMoreInteractions(effect);
+  });
+
   testWidgets(
       'calls effect when one of keys is changed from 0.0 to -0.0 and vice versa',
       (tester) async {
@@ -298,6 +321,29 @@ void main() {
     ]);
     verifyNoMoreInteractions(effect);
   });
+
+  testWidgets(
+      'calls effect when first key is two matching 0 with same sign, but second key is different',
+      (tester) async {
+    // Regression test for https://github.com/rrousselGit/flutter_hooks/issues/384
+    parameters = [-0, 42];
+    await tester.pumpWidget(builder());
+
+    verifyInOrder([
+      effect(),
+      unrelated(),
+    ]);
+    verifyNoMoreInteractions(effect);
+
+    parameters = [-0, 43];
+    await tester.pumpWidget(builder());
+
+    verifyInOrder([
+      effect(),
+      unrelated(),
+    ]);
+    verifyNoMoreInteractions(effect);
+  });
 }
 
 class MockEffect extends Mock {
Original file line number	Diff line number	Diff line change
`@@ -183,12 +183,15 @@ Calling them outside of build method leads to an unstable state and is therefore`
`183`	`183`	`if (curr1 is num && curr2 is num) {`
`184`	`184`	`// Checks if both are NaN`
`185`	`185`	`if (curr1.isNaN && curr2.isNaN) {`
`186`		`- return true;`
	`186`	`+ continue;`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`// Checks if one is 0.0 and the other is -0.0`
`190`	`190`	`if (curr1 == 0 && curr2 == 0) {`
`191`		`- return curr1.isNegative == curr2.isNegative;`
	`191`	`+ if (curr1.isNegative != curr2.isNegative) {`
	`192`	`+ return false;`
	`193`	`+ }`
	`194`	`+ continue;`
`192`	`195`	`}`
`193`	`196`	`}`
`194`	`197`