This repository was archived by the owner on Feb 24, 2020. It is now read-only.
image: set the header instead of adding it - #3796
#3796Merged
iaguis merged 1 commit intoSep 18, 2017
rkt:masterrkt/rkt:masterfrom
JulienBalestra:rkt-fetch-headerJulienBalestra/rkt:rkt-fetch-headerCopy head branch name to clipboard
Merged
image: set the header instead of adding it#3796iaguis merged 1 commit intorkt:masterrkt/rkt:masterfrom JulienBalestra:rkt-fetch-headerJulienBalestra/rkt:rkt-fetch-headerCopy head branch name to clipboard
iaguis merged 1 commit into
rkt:masterrkt/rkt:masterfrom
JulienBalestra:rkt-fetch-headerJulienBalestra/rkt:rkt-fetch-headerCopy head branch name to clipboard
Conversation
Member
|
Thanks for tracking this down to the relevant golang 1.8 behavioral change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The go http/client changes its behavior for redirect and header's copy since the go 1.8:
The ETag header is added and sent twice in the http header request as mentioned in #3678.
This behavior was tracked by ARCH users because they bumped to go1.8 earlier.
As the last release (github v1.28.1) bumped to go1.8, the problem is now present globally.