Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(rivetkit-core): stop scrubbing actor/not_found error message#5475

Open
abcxff wants to merge 1 commit into
mainrivet-dev/rivet:mainfrom
stack/fix-rivetkit-core-stop-scrubbing-actor-not_found-error-message-nmzoutkqrivet-dev/rivet:stack/fix-rivetkit-core-stop-scrubbing-actor-not_found-error-message-nmzoutkqCopy head branch name to clipboard
Open

fix(rivetkit-core): stop scrubbing actor/not_found error message#5475
abcxff wants to merge 1 commit into
mainrivet-dev/rivet:mainfrom
stack/fix-rivetkit-core-stop-scrubbing-actor-not_found-error-message-nmzoutkqrivet-dev/rivet:stack/fix-rivetkit-core-stop-scrubbing-actor-not_found-error-message-nmzoutkqCopy head branch name to clipboard

Conversation

@abcxff

@abcxff abcxff commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/rivet

Get stack: forklift get 5475
Push local edits: forklift submit
Merge when ready: forklift merge 5475

change nmzoutkq

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review

Small, well-scoped fix. Confirmed the bug: framework_error_status in registry/http.rs already mapped ("actor", "not_found") to 404, but public_error_status_code in error.rs (which gates client_error_message/client_error_metadata via is_client_error_public) was missing that pair. The HTTP status line was correct, but the response body message/metadata was getting scrubbed to the generic internal-error message; this fix aligns the two. ActorRuntime::NotFound's resource/id fields (route path, actor id, queue handler name) aren't sensitive, so making them public is safe.

One likely missed sibling case

("actor", "method_not_allowed") has the identical bug and doesn't appear to be fixed by this PR:

  • framework_error_status("actor", "method_not_allowed") in registry/http.rs:1115 returns 405.
  • MethodNotAllowed (registry/mod.rs:397-401, group actor, code method_not_allowed) is actually constructed and returned at 3 call sites in registry/http.rs (lines 190, 310, 587).
  • public_error_status_code still has no ("actor", "method_not_allowed") entry, so those responses keep the correct 405 status but a scrubbed body message, same as not_found before this fix.

Worth adding ("actor", "method_not_allowed") => Some(405) in the same change since it's the same root cause and trivial to include.

Test coverage

No regression test accompanies this fix. Since the bug was exactly "status code map and public-message map silently drifted apart," a small test asserting public_error_status_code("actor", "not_found") == Some(404) (and ideally asserting client_error_message/is_client_error_public return the real message for this pair) would catch future drift, and would also have caught the method_not_allowed gap noted above.

Nothing else to flag. The change is minimal, has no security implications (message content is not sensitive), and doesn't touch any load-bearing lifecycle logic.

@railway-app

railway-app Bot commented Jul 23, 2026

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5475 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Jul 23, 2026 at 8:59 pm
frontend-inspector 😴 Sleeping (View Logs) Web Jul 23, 2026 at 8:56 pm
kitchen-sink 😴 Sleeping (View Logs) Web Jul 23, 2026 at 8:55 pm
frontend-cloud 😴 Sleeping (View Logs) Web Jul 23, 2026 at 8:55 pm
ladle ✅ Success (View Logs) Web Jul 23, 2026 at 8:49 pm
mcp-hub ✅ Success (View Logs) Web Jul 23, 2026 at 8:48 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.