move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react#8282
Draft
dkirchhof wants to merge 11 commits into
rescript-lang:masterrescript-lang/rescript:masterfrom
dkirchhof:remove-domprops-and-domstylesdkirchhof/rescript:remove-domprops-and-domstylesCopy head branch name to clipboard
Draft
move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react#8282dkirchhof wants to merge 11 commits intorescript-lang:masterrescript-lang/rescript:masterfrom dkirchhof:remove-domprops-and-domstylesdkirchhof/rescript:remove-domprops-and-domstylesCopy head branch name to clipboard
dkirchhof wants to merge 11 commits into
rescript-lang:masterrescript-lang/rescript:masterfrom
dkirchhof:remove-domprops-and-domstylesdkirchhof/rescript:remove-domprops-and-domstylesCopy head branch name to clipboard
Conversation
Member
|
@cknitt we still have the npm package over at https://github.com/rescript-lang/rescript-react right? So the moved files here don't reflect that? |
Member
Yeah I already proposed before to do this, at least temporarily while we are moving things around. Related: #7525. I haven't finished that one unfortunately because of the analysis test output changes it caused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s. rescript-lang/rescript-react#151