Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

The parser does not ignore subsequent open multi-line comment /* inside /** or /* #7508

Copy link
Copy link

Description

@illusionalsagacity
Issue body actions

Thank you for filing! Check list:

  • Is it a bug? Usage questions should often be asked in the forum instead.
  • Concise, focused, friendly issue title & description.
  • A minimal, reproducible example.
  • OS and browser versions, if relevant.
  • Is it already fixed in master? Instructions

I found an odd case while I was writing some documentation for the MSW bindings I maintain:

/**
Creates a handler that intercepts any HTTP request method for the given URL pattern.

https://mswjs.io/docs/api/http/all

\```rescript
MSW.Http.all(
  #URL("/api/*"), // <- this is the issue
  async ({ request, cookies, params }) => {
    MSW.HttpResponse.text("Intercepted any method", {status: 200})
  }
)
\```
*/

Which produces the following syntax error:

  Syntax error!
  /.../rescript-msw/src/MSW__Http.res:23:1-311:0

   21 │ }
   22 │ 
   23 │ /**
   24 │ Creates a handler that intercepts any HTTP request method for the give
      │ n URL pattern.
    . │ ...
  310 │ ) => MSW__Common.requestHandler = "options"
  311 │ 

  This comment seems to be missing a closing `*/`

As a minimal example:

/**
/*
*/
let hello = "world"

Playground link

This is valid javascript / typescript so I'd expect this to work, and also the error message was a little confusing.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.