Correct issue label CSS class#1287
Merged
sindresorhus merged 1 commit intoMay 2, 2018
Merged
Correct issue label CSS class#1287
Conversation
sindresorhus
approved these changes
May 1, 2018
Member
I don't think we should bother doing GHE backward support unless something is broken. Here it's fine, just not optimal looking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the issue labels were quite big. After looking into the code, I discovered that the current CSS selector doesn't seem to be valid any longer. GitHub has renamed the
labelclass toIssueLabelboth on pull requests and issues.I could also change it to
.js-issue-row .label, .js-issue-row .IssueLabel {to be backwards-compatible (think maybe older GitHub enterprise versions?).