Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: support write the types of pointer of simple data types (#2745)#2753

Merged
ofekshenawa merged 4 commits into
redis:masterredis/go-redis:masterfrom
tzq0301:mastertzq0301/go-redis:masterCopy head branch name to clipboard
Oct 31, 2023
Merged

feat: support write the types of pointer of simple data types (#2745)#2753
ofekshenawa merged 4 commits into
redis:masterredis/go-redis:masterfrom
tzq0301:mastertzq0301/go-redis:masterCopy head branch name to clipboard

Conversation

@tzq0301

@tzq0301 tzq0301 commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@ofekshenawa

Copy link
Copy Markdown
Collaborator

Hey,
Do you think you might be able to write a unit test that validates this? WDYT?

@tzq0301

tzq0301 commented Oct 29, 2023

Copy link
Copy Markdown
Contributor Author

Hey, Do you think you might be able to write a unit test that validates this? WDYT?

Hello. I have added a unit test for WriteArg to test the behaviour of the simple data types and the pointer type of them.

The result of the unit test shows that WriteArg the value of the pointer of the simple data types have the same behaviour as the non-pointer types after the modification of internal/proto/writer.go in this PR.

@ofekshenawa
ofekshenawa merged commit 15682e3 into redis:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] HSet struct with pointer

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.