Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d150ccd

Browse filesBrowse files
dwcullopdwcullop
authored
Bump main to 10.0-preview (#1128)
* Bump main to 10.0-preview Cut main over to the next major preview so packages built from main are versioned 10.0.0-preview.{height} instead of 9.5-preview.{height}. This is a manual version.json edit (the sanctioned override path), so the PR carries the 'manual-version-edit' label; the major bump 9 -> 10 carries 'breaking-change' per pr-version-check.yml. * Fix pr-version-check to match existing 'breaking change' label The workflow gated major bumps on a 'breaking-change' (hyphen) label that does not exist in the repo; the actual label is 'breaking change' (space). Align the check and its messages with the real label so a labeled major bump passes.
1 parent d26b63c commit d150ccd
Copy full SHA for d150ccd

2 files changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/pr-version-check.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/pr-version-check.yml
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
$isBotBumpPr = ($env:PR_AUTHOR -eq 'github-actions[bot]') -and ($env:HEAD_REF -like 'bot/bump-*' -or $env:HEAD_REF -like 'bot/promote-*')
3636
3737
$labels = $env:LABELS_JSON | ConvertFrom-Json
38-
$isBreaking = $labels -contains 'breaking-change'
38+
$isBreaking = $labels -contains 'breaking change'
3939
$isManualEdit = $labels -contains 'manual-version-edit'
4040
4141
# Reject any human-authored PR that touches version.json unless explicitly
@@ -84,11 +84,11 @@ jobs:
8484
# Unconditional check: if this PR changes the major in version.json, it MUST be
8585
# labeled breaking-change. Catches unlabeled major-version edits.
8686
if ($headMajor -ne $baseMajor -and -not $isBreaking) {
87-
throw "This PR changes version.json's major from $baseMajor to $headMajor but is not labeled 'breaking-change'. Major-version changes must be tagged."
87+
throw "This PR changes version.json's major from $baseMajor to $headMajor but is not labeled 'breaking change'. Major-version changes must be tagged."
8888
}
8989
9090
if (-not $isBreaking) {
91-
Write-Host "PR is not labeled 'breaking-change' and does not change the major; no further checks."
91+
Write-Host "PR is not labeled 'breaking change' and does not change the major; no further checks."
9292
exit 0
9393
}
9494
@@ -122,9 +122,9 @@ jobs:
122122
$expectedMajor = $latestMajor + 1
123123
if ($headMajor -ne $expectedMajor) {
124124
if ($headMajor -le $latestMajor) {
125-
$msg = "PR is labeled breaking-change but its version.json major ($headMajor) is not greater than the latest stable release major ($latestMajor; tag '$latestStable'). Run the 'Bump main to next major preview' workflow with next_major=$expectedMajor first, then rebase this PR onto the updated main."
125+
$msg = "PR is labeled 'breaking change' but its version.json major ($headMajor) is not greater than the latest stable release major ($latestMajor; tag '$latestStable'). Run the 'Bump main to next major preview' workflow with next_major=$expectedMajor first, then rebase this PR onto the updated main."
126126
} else {
127-
$msg = "PR is labeled breaking-change but its version.json major ($headMajor) skips past major $expectedMajor. Main must be at exactly latest_stable_major + 1 ($latestMajor + 1 = $expectedMajor). Reset main to $expectedMajor.0-preview.{height} before merging this PR."
127+
$msg = "PR is labeled 'breaking change' but its version.json major ($headMajor) skips past major $expectedMajor. Main must be at exactly latest_stable_major + 1 ($latestMajor + 1 = $expectedMajor). Reset main to $expectedMajor.0-preview.{height} before merging this PR."
128128
}
129129
throw $msg
130130
}
Collapse file

‎version.json‎

Copy file name to clipboardExpand all lines: version.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "9.5-preview.{height}",
2+
"version": "10.0-preview.{height}",
33
"publicReleaseRefSpec": [
44
"^refs/heads/main$", // main publishes pre-release packages
55
"^refs/heads/release/\\d+\\.x$" // release/<major>.x branches publish stable packages

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.