Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d925a8d

Browse filesBrowse files
authored
Flight client error stack (#25560)
restore error message into stack for flight prod errors
1 parent 996b00b commit d925a8d
Copy full SHA for d925a8d

2 files changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎packages/react-client/src/ReactFlightClient.js‎

Copy file name to clipboardExpand all lines: packages/react-client/src/ReactFlightClient.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ export function resolveErrorProd(
646646
' builds to avoid leaking sensitive details. A digest property is included on this error instance which' +
647647
' may provide additional details about the nature of the error.',
648648
);
649-
error.stack = '';
649+
error.stack = 'Error: ' + error.message;
650650
(error: any).digest = digest;
651651
const errorWithDigest: ErrorWithDigest = (error: any);
652652
const chunks = response._chunks;
Collapse file

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Copy file name to clipboardExpand all lines: packages/react-client/src/__tests__/ReactFlight-test.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ describe('ReactFlight', () => {
5757
' may provide additional details about the nature of the error.',
5858
);
5959
expect(this.state.error.digest).toContain(this.props.expectedMessage);
60+
expect(this.state.error.stack).toBe(
61+
'Error: ' + this.state.error.message,
62+
);
6063
}
6164
}
6265
render() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.