Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Drop unused Python test dependencies#503

Open
alexbarghi-nv wants to merge 3 commits into
rapidsai:mainrapidsai/cugraph-gnn:mainfrom
alexbarghi-nv:agent/drop-torchdataalexbarghi-nv/cugraph-gnn:agent/drop-torchdataCopy head branch name to clipboard
Open

Drop unused Python test dependencies#503
alexbarghi-nv wants to merge 3 commits into
rapidsai:mainrapidsai/cugraph-gnn:mainfrom
alexbarghi-nv:agent/drop-torchdataalexbarghi-nv/cugraph-gnn:agent/drop-torchdataCopy head branch name to clipboard

Conversation

@alexbarghi-nv

@alexbarghi-nv alexbarghi-nv commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • remove unused torchdata and pydantic entries from the Python test dependency matrix
  • regenerate the tracked conda development and all-dependencies environments

Impact

cuGraph-GNN test environments no longer install the unused torchdata and pydantic packages.

Validation

  • pre-commit run rapids-dependency-file-generator --all-files
  • git diff --check
  • confirmed no remaining torchdata or pydantic references outside changelog/history

@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alexbarghi-nv alexbarghi-nv self-assigned this Jul 23, 2026
@alexbarghi-nv alexbarghi-nv added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 23, 2026
@alexbarghi-nv alexbarghi-nv changed the title Drop torchdata dependency Drop unused Python test dependencies Jul 23, 2026
@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 0b4b514

@alexbarghi-nv
alexbarghi-nv marked this pull request as ready for review July 23, 2026 18:41
@alexbarghi-nv
alexbarghi-nv requested review from a team as code owners July 23, 2026 18:41
@alexbarghi-nv
alexbarghi-nv requested a review from jameslamb July 23, 2026 18:41
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes torchdata and pydantic from the cuGraph-PyG Python test dependency matrix in dependencies.yaml and regenerates all derived conda environment YAML files. No Python source or test files import either package, confirming they are genuinely unused.

  • dependencies.yaml: deletes the specific conda block (including the no_pytorch matrix guard) that previously injected torchdata and pydantic into test_python_cugraph_pyg.
  • Eight conda YAML files regenerated consistently, each dropping both packages.

Confidence Score: 5/5

Safe to merge — removes two packages that are not imported anywhere in the codebase.

The change is purely additive in the negative sense: two packages are removed from test dependency lists and confirmed absent from all Python source and test files. All eight generated YAML files are consistent with the dependencies.yaml source, and the PR description notes a successful rapids-dependency-file-generator run.

Files Needing Attention: No files require special attention.

Important Files Changed

Filename Overview
dependencies.yaml Removes the specific conda block that installed torchdata and pydantic under test_python_cugraph_pyg; the source of truth for all generated env files.
conda/environments/all_cuda-129_arch-x86_64.yaml Regenerated: drops pydantic and torchdata entries, consistent with dependencies.yaml change.
python/cugraph-pyg/conda/cugraph_pyg_dev_cuda-129_arch-x86_64.yaml Regenerated dev env: drops pydantic and torchdata, consistent with dependencies.yaml change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[dependencies.yaml] -->|rapids-dependency-file-generator| B[conda/environments/*.yaml]
    A -->|rapids-dependency-file-generator| C[python/cugraph-pyg/conda/*.yaml]
    A -- removes --> D[torchdata]
    A -- removes --> E[pydantic]
    D & E -->|not imported in any .py file| F[safe to drop]
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into agent/drop-torc..." | Re-trigger Greptile

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely recall looking into these before and finding a comment in code (here? cuGraph? don't remember) that these were needed to provide optional dependencies for some relevant code path in sentence-transformers or ogb or something.

Anyway... can't find that and if you're happy with what you see in CI (nothing getting skipped that shouldn't, etc.) then great, happy to see these drop out of the testing dependencies!

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

I vaguely recall looking into these before and finding a comment in code (here? cuGraph? don't remember) that these were needed to provide optional dependencies for some relevant code path in sentence-transformers or ogb or something.

Anyway... can't find that and if you're happy with what you see in CI (nothing getting skipped that shouldn't, etc.) then great, happy to see these drop out of the testing dependencies!

torchdata was for DGL I believe.
pydantic I'm not sure about, but it's definitely not needed for CI. Let me double-check that none of the examples need it.

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

I vaguely recall looking into these before and finding a comment in code (here? cuGraph? don't remember) that these were needed to provide optional dependencies for some relevant code path in sentence-transformers or ogb or something.
Anyway... can't find that and if you're happy with what you see in CI (nothing getting skipped that shouldn't, etc.) then great, happy to see these drop out of the testing dependencies!

torchdata was for DGL I believe. pydantic I'm not sure about, but it's definitely not needed for CI. Let me double-check that none of the examples need it.

I've confirmed again that pydantic can safely be dropped. I think it was also for DGL.

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 03726e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.