Drop unused Python test dependencies#503
Drop unused Python test dependencies#503alexbarghi-nv wants to merge 3 commits intorapidsai:mainrapidsai/cugraph-gnn:mainfrom alexbarghi-nv:agent/drop-torchdataalexbarghi-nv/cugraph-gnn:agent/drop-torchdataCopy head branch name to clipboard
Conversation
|
/ok to test 0b4b514 |
Greptile SummaryRemoves
Confidence Score: 5/5Safe to merge — removes two packages that are not imported anywhere in the codebase. The change is purely additive in the negative sense: two packages are removed from test dependency lists and confirmed absent from all Python source and test files. All eight generated YAML files are consistent with the dependencies.yaml source, and the PR description notes a successful rapids-dependency-file-generator run. Files Needing Attention: No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[dependencies.yaml] -->|rapids-dependency-file-generator| B[conda/environments/*.yaml]
A -->|rapids-dependency-file-generator| C[python/cugraph-pyg/conda/*.yaml]
A -- removes --> D[torchdata]
A -- removes --> E[pydantic]
D & E -->|not imported in any .py file| F[safe to drop]
Reviews (2): Last reviewed commit: "Merge branch 'main' into agent/drop-torc..." | Re-trigger Greptile |
jameslamb
left a comment
There was a problem hiding this comment.
I vaguely recall looking into these before and finding a comment in code (here? cuGraph? don't remember) that these were needed to provide optional dependencies for some relevant code path in sentence-transformers or ogb or something.
Anyway... can't find that and if you're happy with what you see in CI (nothing getting skipped that shouldn't, etc.) then great, happy to see these drop out of the testing dependencies!
|
I've confirmed again that pydantic can safely be dropped. I think it was also for DGL. |
|
/ok to test 03726e3 |
Summary
torchdataandpydanticentries from the Python test dependency matrixImpact
cuGraph-GNN test environments no longer install the unused
torchdataandpydanticpackages.Validation
pre-commit run rapids-dependency-file-generator --all-filesgit diff --checktorchdataorpydanticreferences outside changelog/history