[ci skip] Fix explanation of controller callbacks with blocks#58229
Open
flavio-b wants to merge 1 commit into
Open
[ci skip] Fix explanation of controller callbacks with blocks#58229flavio-b wants to merge 1 commit into
flavio-b wants to merge 1 commit into
Conversation
Clarify that blocks passed to controller callbacks runs in the context of the controller instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The current Guides say that "action callback does not run in the scope of the controller", when you pass a block to the callback.
However, the block actually does run in the scope of the controller. You can test it with:
Running the callback block in the context of the instance is the behaviour you get with model callbacks, so I thought it was odd that controller callbacks would work differently.
The AI did some digging, and it seems like the limitation of relying on a
controllerargument dates back to Rails 2.3. Then Rails 3 changed it to defining a method on the controller. Rails 4.1 changed it to useinstance_exec, which is used to this day.Detail
Removed the outdated information and tried to keep the intention and examples about the same.