Fix pytest.skip for MacOS in test_tutorials.py#2547
Merged
Merged
Fix pytest.skip for MacOS in test_tutorials.py#2547
Conversation
pushfoo
pushed a commit
to pushfoo/arcade
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2542 to address #2534
@einarf - I changed to check
sys.platformsince it's consistently used in the Arcade package and tests.You were using
platform.system()which is recommended herehttps://stackoverflow.com/questions/1854/how-to-identify-which-os-python-is-running-on
but it wasn't working on my Mac because it requires "Darwin" with capital "D" and you had used the lower-case "darwin" that
sys.platformuses.This should be OK now.