Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove deprecated function read_tmx#2528

Merged
einarf merged 1 commit into
pythonarcade:developmentpythonarcade/arcade:developmentfrom
cdeil:rm-read_tmxcdeil/arcade:rm-read_tmxCopy head branch name to clipboard
Feb 1, 2025
Merged

Remove deprecated function read_tmx#2528
einarf merged 1 commit into
pythonarcade:developmentpythonarcade/arcade:developmentfrom
cdeil:rm-read_tmxcdeil/arcade:rm-read_tmxCopy head branch name to clipboard

Conversation

@cdeil

@cdeil cdeil commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Looks like this read_tmx function was removed 4 years ago in #891 and is non-functional since.

OK to remove now?

@einarf einarf requested a review from Cleptomania January 31, 2025 17:14
@einarf

einarf commented Feb 1, 2025

Copy link
Copy Markdown
Member

This should probably have followed the normal deprecation pattern with a warning on earlier versions BUT 3.0 is such a huge leap forward it probably makes more sense to remove this now.

@einarf einarf merged commit e3e02b6 into pythonarcade:development Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.