Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update Camera Shake 2D with feature requested in #2429#2448

Merged
DragonMoffon merged 2 commits into
developmentpythonarcade/arcade:developmentfrom
camera-shake-2dpythonarcade/arcade:camera-shake-2dCopy head branch name to clipboard
Nov 13, 2024
Merged

Update Camera Shake 2D with feature requested in #2429#2448
DragonMoffon merged 2 commits into
developmentpythonarcade/arcade:developmentfrom
camera-shake-2dpythonarcade/arcade:camera-shake-2dCopy head branch name to clipboard

Conversation

@DragonMoffon

Copy link
Copy Markdown
Collaborator

Thank you, @bunny-therapist, for the feature request!

Also adds the context manager interface, allowing for the following neat code:

with self.shake, self.camera.activate():
  # draw commands that want to be drawn with screen shake,
# outside of the with block the shake has been removed, and the camera has been deactivated.

closes #2429 and #2446 (Thank you for the PR, but due to the extra feature I've made my own PR)

@DragonMoffon DragonMoffon changed the title Update Camera Shake 2D with feature requested in #2429 Update Camera Shake 2D with feature requested from #2429 Nov 13, 2024
@DragonMoffon DragonMoffon changed the title Update Camera Shake 2D with feature requested from #2429 Update Camera Shake 2D with feature requested in #2429 Nov 13, 2024
@DragonMoffon DragonMoffon merged commit 575d662 into development Nov 13, 2024
@einarf einarf deleted the camera-shake-2d branch December 7, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add direction to ScreenShake2D

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.