Fix math point types#2430
Merged
pushfoo merged 7 commits intoJan 1, 2025
Merged
Fix math point types#2430
Conversation
pushfoo
requested changes
Oct 21, 2024
pushfoo
left a comment
Member
There was a problem hiding this comment.
TL;DR: I'm undecided on the Point2 change, but I have suggestions on the doc and the doc
@DragonMoffon any thoughts on consistency for Point2 vs the perf dangers of Vec2?
@Rapen765 The CI's linter complaints. Could you please try the following in your local repo clone?
- Make sure your venv's activated
./make.py format && ./make.py ruff- Commit & push
8 tasks
Collaborator
|
I def think Point2 should be used over tuple[float, float] everywhere. The only place it shouldn't be used is anything that returns a |
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
pushfoo
approved these changes
Jan 1, 2025
Member
|
Ty for the contribution and sorry for the wait! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed functions' return type from
tuple[float, float]toPoint2.Fixed documentation of
rand_vec_magnitudeandrand_on_circle.