Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Unify text input events onto a base class and rename UITextEvent#2312

Merged
eruvanos merged 4 commits into
developmentpythonarcade/arcade:developmentfrom
text-event-updatespythonarcade/arcade:text-event-updatesCopy head branch name to clipboard
Jul 25, 2024
Merged

Unify text input events onto a base class and rename UITextEvent#2312
eruvanos merged 4 commits into
developmentpythonarcade/arcade:developmentfrom
text-event-updatespythonarcade/arcade:text-event-updatesCopy head branch name to clipboard

Conversation

@pushfoo

@pushfoo pushfoo commented Jul 25, 2024

Copy link
Copy Markdown
Member
  • Rename UITextEvent to less misleading UITextInputEvent
  • Add a UITextEvent baseclass as in mouse events
    • Instead of holding data, it allows responding to text input field events
    • It holds no data, but that's okay
  • Document what UITextInputEvent actually does with a link to pyglet

Intersphinx is being annoying and my local Sphinx is acting up, so I'm linking the ugly way for now since it helps ship 3.0 faster.

@pushfoo pushfoo requested a review from eruvanos July 25, 2024 18:10
@eruvanos eruvanos merged commit eb85958 into development Jul 25, 2024
@eruvanos eruvanos deleted the text-event-updates branch July 25, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.