Fix issues for python 3.12#68
Merged
mergify[bot] merged 2 commits intoJun 19, 2023
python-virtualenvwrapper:mainpython-virtualenvwrapper/virtualenvwrapper:mainfrom
parona-source:python3.12parona-source/virtualenvwrapper:python3.12Copy head branch name to clipboard
Merged
Fix issues for python 3.12#68mergify[bot] merged 2 commits intopython-virtualenvwrapper:mainpython-virtualenvwrapper/virtualenvwrapper:mainfrom parona-source:python3.12parona-source/virtualenvwrapper:python3.12Copy head branch name to clipboard
mergify[bot] merged 2 commits into
python-virtualenvwrapper:mainpython-virtualenvwrapper/virtualenvwrapper:mainfrom
parona-source:python3.12parona-source/virtualenvwrapper:python3.12Copy head branch name to clipboard
Conversation
* Python 3.11 deprecated distutils and Python 3.12 completely removed it * Removed find_package_data entirely as there was not package data to install Signed-off-by: Alfred Wingate <parona@protonmail.com>
* setuptools isn't included in ensurepip in Python 3.12 * Use pip install instead of invoking setup.py directly, due to setuptools discouraging it and allowing updates for the tests packages to use PEP517 compliant build system to done seamlessly. Also don't need to invoke pip install -r requirements.txt. * editable_mode=compat is comparable to python setup.py develop. But setuptools doesn't guarantee the longevity of the feature. Removal of support for the legacy method would be a thing consider. Signed-off-by: Alfred Wingate <parona@protonmail.com>
dhellmann
approved these changes
Jun 19, 2023
dhellmann
left a comment
Contributor
There was a problem hiding this comment.
Nice cleanup work, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main things are the final removal of distutils and no setuptools by default in a venv.
Removed all of find_package_data because I didn't see its use, I could've removed just the distutils bits from it and it would've worked the same.
There should be consideration for the removal legacy develop install support and tests. https://setuptools.pypa.io/en/latest/userguide/development_mode.html#legacy-behavior
Also used pip install instead python setup.py because its discouraged by setuptools, it allows me to opt out of using pip install -r requirements.txt and it allows PEP517 build systems to be added to the test packages at a later time without extra changes.
Tested for python3.8, python3.9, python3.10, python3.11 and python3.12 on Gentoo Linux.