Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 24, 2024

Note that TransactionPartnerUser was implemented to be a timedelta object in the spirit of #4575

  • Shortcuts
    • Chat.send_gift
    • [ ] CallbackQuery.reply_gift?
    • User.send_gift
  • Defaults integration of text_parse_mode
  • extend constants

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Nov 24, 2024
@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 24, 2024
42 tasks
@codecov
Copy link

codecov bot commented Nov 24, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
6061 2 6059 254
View the top 2 failed tests by shortest run time
tests.test_bot.TestBotWithoutRequest::test_camel_case_aliases[Bot.get_available_gifts]
Stack Traces | 0.002s run time
self = <tests.test_bot.TestBotWithoutRequest object at 0x0000020F6FA493B0>
bot_class = <class 'telegram._bot.Bot'>, bot_method_name = 'get_available_gifts'
bot_method = <function Bot.get_available_gifts at 0x0000020F6D0F4360>

    @bot_methods()
    def test_camel_case_aliases(self, bot_class, bot_method_name, bot_method):
        camel_case_name = to_camel_case(bot_method_name)
        camel_case_function = getattr(bot_class, camel_case_name, False)
>       assert camel_case_function is not False, f"{camel_case_name} not found"
E       AssertionError: getAvailableGifts not found
E       assert False is not False

tests\test_bot.py:438: AssertionError
tests.test_bot.TestBotWithoutRequest::test_camel_case_aliases[ExtBot.get_available_gifts]
Stack Traces | 0.002s run time
self = <tests.test_bot.TestBotWithoutRequest object at 0x0000020F6FA800A0>
bot_class = <class 'telegram.ext._extbot.ExtBot'>
bot_method_name = 'get_available_gifts'
bot_method = <function ExtBot.get_available_gifts at 0x0000020F6E271580>

    @bot_methods()
    def test_camel_case_aliases(self, bot_class, bot_method_name, bot_method):
        camel_case_name = to_camel_case(bot_method_name)
        camel_case_function = getattr(bot_class, camel_case_name, False)
>       assert camel_case_function is not False, f"{camel_case_name} not found"
E       AssertionError: getAvailableGifts not found
E       assert False is not False

tests\test_bot.py:438: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review November 27, 2024 05:51
@Bibo-Joshi Bibo-Joshi merged commit e785649 into api-8.0 Nov 28, 2024
21 of 22 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-8.0-gifts-transationpartneruser branch November 28, 2024 18:43
@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 28, 2024
30 tasks
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bit weird we have to do a class for a list of objects :D

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.