Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bot API 8.0: Add New Parameters to create_invoice_link #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 1 commit into from
Nov 28, 2024
Merged

Bot API 8.0: Add New Parameters to create_invoice_link #4568

Bibo-Joshi merged 1 commit into from
Nov 28, 2024

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 17, 2024

Note that I allowed datetime.timedelta input for subscription_period as convenience datatime instead of just bare integer seconds

@Bibo-Joshi Bibo-Joshi added ⚙️ bot-api affected functionality: bot-api 🔌 enhancement pr description: enhancement labels Nov 17, 2024
@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 17, 2024
Closed
42 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
6007 1 6006 258
View the top 1 failed tests by shortest run time 
tests._files.test_animation.TestAnimationWithoutRequest::test_expected_values
Stack Traces | 0.001s run time 
self = <tests._files.test_animation.TestAnimationWithoutRequest object at 0x105e1b2b0>
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATI4i2c6TNgPam1sXo1__HIMXZdxzaY2AAJsFAAC22jRUTL7cULXKUIUAQAHbQ...FAAC22jRUTL7cULXKUIUAQAHbQADNgQ', file_size=4449, file_unique_id='AQADbBQAAtto0VFy', height=180, width=320), width=640)

    def test_expected_values(self, animation):
>       assert animation.mime_type == self.mime_type
E       AssertionError: assert 'image/gif' == 'video/mp4'
E         
E         - video/mp4
E         + image/gif

tests/_files/test_animation.py:69: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@Bibo-Joshi Bibo-Joshi changed the title Add New Parameters to create_invoice_link Bot API 8.0: Add New Parameters to create_invoice_link Nov 24, 2024
@Bibo-Joshi Bibo-Joshi merged commit ec9f92a into api-8.0 Nov 28, 2024
21 of 23 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-8.0-createinvoicelink branch November 28, 2024 18:10
@Bibo-Joshi Bibo-Joshi mentioned this pull request Nov 28, 2024
Merged
30 tasks
Poolitzer
Poolitzer reviewed Nov 30, 2024
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bibo-Joshi added a commit that referenced this pull request Dec 1, 2024
@Bibo-Joshi
Full Support for Bot API 8.0 (#4566, #4568, #4570, #4571, #4574, #4576,
ef1685c 
#4572)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Poolitzer Poolitzer Poolitzer left review comments

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api 🔌 enhancement pr description: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bibo-Joshi @Poolitzer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.