Don't call make clean or pip in tox#8754
Merged
Merged
Don't call make clean or pip in tox#8754
make clean or pip in tox#8754Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/tox-dev/tox-uv is a tox plugin that uses uv instead of pip. By default, it doesn't install pip into the tox virtualenv.
We don't actually need to call
pip install .here, because tox itself installs Pillow into its virtualenv.And we don't need to run
make cleaneither, because again tox installs into its own virtualenv, and the .so files are found at paths like:And not like these that
pip install .creates: