Fix SEGFAULT from calling FT_New_Face/FT_Done_Face in multiple threads#8496
Merged
radarhere merged 3 commits intoOct 26, 2024
python-pillow:mainpython-pillow/Pillow:mainfrom
lysnikolaou:fix-font-face-threading-crashlysnikolaou/Pillow:fix-font-face-threading-crashCopy head branch name to clipboard
Merged
Fix SEGFAULT from calling FT_New_Face/FT_Done_Face in multiple threads#8496radarhere merged 3 commits intopython-pillow:mainpython-pillow/Pillow:mainfrom lysnikolaou:fix-font-face-threading-crashlysnikolaou/Pillow:fix-font-face-threading-crashCopy head branch name to clipboard
radarhere merged 3 commits into
python-pillow:mainpython-pillow/Pillow:mainfrom
lysnikolaou:fix-font-face-threading-crashlysnikolaou/Pillow:fix-font-face-threading-crashCopy head branch name to clipboard
Conversation
nulano
reviewed
Oct 24, 2024
nulano
left a comment
Contributor
There was a problem hiding this comment.
Is anything here actually using the new changes in pythoncapi_compat.h?
There's no reason to stick with an old version, but I'm curious if there is a reason for updating it in what looks like an unrelated PR?
Contributor
Author
No, upgrading However, I thought that it might be okay for the header to be upgraded anyway, that's why I left it in. |
radarhere
reviewed
Oct 25, 2024
nulano
reviewed
Oct 25, 2024
radarhere
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8454.
Changes proposed in this pull request:
FT_New_FaceorFT_Done_Faceare called.pythoncapi_compat.hto the latest version.