Added MPEG accept function#7999
Merged
Merged
Added MPEG accept function#7999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating MpegImagePlugin's
_openfunction,Pillow/src/PIL/MpegImagePlugin.py
Lines 65 to 71 in eee633c
this is saying that MPEG images must start with
b"\x00\x00\x01\xb3".This is what https://en.wikipedia.org/wiki/List_of_file_signatures describes as the magic number for "MPEG-1 video and MPEG-2 video (MPEG-1 Part 2 and MPEG-2 Part 2)"
So I have added an
_acceptfunction to check the magic number. This is a minor performance improvement, allowing non-MPEG images to be rejected without further file reading.I have also added tests for the MPEG format, as those were not present. These are based on the first few tests of test_file_bufrstub.py.