Document that QoiImagePlugin uses Python for decoding#7937
Merged
Merged
Document that QoiImagePlugin uses Python for decoding#7937
Conversation
Member
|
Shall we also mention https://github.com/kodonnell/qoi or https://pypi.org/project/qoi/? It's not a Pillow plugin but can be a useful alternative. |
Member
Author
|
I've pushed a commit. Now that AppVeyor is skipped, I was able to do so quite quickly! |
hugovk
reviewed
Apr 3, 2024
| Pillow identifies and reads images in Quite OK Image format. | ||
| Pillow reads images in Quite OK Image format, using a Python decoder. If you wish to | ||
| write code specifically for this format, https://pypi.org/project/qoi is an alternative | ||
| library that interfaces with NumPy. |
Member
There was a problem hiding this comment.
Mention C somehow, so they know it's faster?
Suggested change
| library that interfaces with NumPy. | |
| library written in C that interfaces with NumPy. |
Member
Author
There was a problem hiding this comment.
"written in C" sounds to me like the entire library is in C. How about "that uses C to decode the image"?
Member
There was a problem hiding this comment.
Yeah, something like that's fine too.
Member
Author
There was a problem hiding this comment.
Cool, I've pushed a commit for that.
hugovk
approved these changes
Apr 4, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
nulano
reviewed
Apr 4, 2024
Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
nulano
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7922
#7922 (comment)