feat(ldapobject): allow passing uri=None in SimpleLDAPObject#593
Closed
spaceone wants to merge 1 commit into
python-ldap:mainpython-ldap/python-ldap:mainfrom
spaceone:feat/followup-ldap-initialize-Nonespaceone/python-ldap:feat/followup-ldap-initialize-NoneCopy head branch name to clipboard
Closed
feat(ldapobject): allow passing uri=None in SimpleLDAPObject#593spaceone wants to merge 1 commit intopython-ldap:mainpython-ldap/python-ldap:mainfrom spaceone:feat/followup-ldap-initialize-Nonespaceone/python-ldap:feat/followup-ldap-initialize-NoneCopy head branch name to clipboard
uri=None in SimpleLDAPObject#593spaceone wants to merge 1 commit into
python-ldap:mainpython-ldap/python-ldap:mainfrom
spaceone:feat/followup-ldap-initialize-Nonespaceone/python-ldap:feat/followup-ldap-initialize-NoneCopy head branch name to clipboard
Conversation
and `ReconnectLDAPObject` to be consistent with `initialize()`. Fixes: 7af3125 Issue: python-ldap#465
Contributor
|
When taken together with pickling (because you opened #587 et al.), how should we deal with situations where ldaprc is different across that boundary? |
Contributor
Author
|
that's a user fault - i guess solve by documentation or ignore it. |
Contributor
|
Sure, maybe add the doc update here since that's what brings the two together? Do we need a pickling test BTW? |
Contributor
|
Closed via 7df168b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and
ReconnectLDAPObjectto be consistent withinitialize().Followup for:
Fixes: 7af3125
Issue: #465