docs: add missing negation in contributing.rst#552
Merged
droideck merged 1 commit intoFeb 22, 2024
python-ldap:mainpython-ldap/python-ldap:mainfrom
ojob:ojob-patch-1-contributing-missing-negationojob/python-ldap:ojob-patch-1-contributing-missing-negationCopy head branch name to clipboard
Merged
docs: add missing negation in contributing.rst#552droideck merged 1 commit intopython-ldap:mainpython-ldap/python-ldap:mainfrom ojob:ojob-patch-1-contributing-missing-negationojob/python-ldap:ojob-patch-1-contributing-missing-negationCopy head branch name to clipboard
droideck merged 1 commit into
python-ldap:mainpython-ldap/python-ldap:mainfrom
ojob:ojob-patch-1-contributing-missing-negationojob/python-ldap:ojob-patch-1-contributing-missing-negationCopy head branch name to clipboard
Conversation
Current description contains a sentence that miss a negative form, contradicting previous sentence and leaving the reader with an ambiguity.
droideck
approved these changes
Dec 2, 2023
droideck
pushed a commit
to droideck/python-ldap
that referenced
this pull request
Oct 7, 2025
Current description contains a sentence that miss a negative form, contradicting previous sentence and leaving the reader with an ambiguity.
droideck
pushed a commit
that referenced
this pull request
Oct 10, 2025
Current description contains a sentence that miss a negative form, contradicting previous sentence and leaving the reader with an ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current description contains a sentence that miss a negative form, contradicting previous sentence and leaving the reader with an ambiguity.
I did not run the tests locally, as 1) the change is in documentation text only 2) this is a fork of current
mainbranch, 3) I made the change online, using GitHub editor.