Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use slapd -Tt instead of slaptest#282

Merged
encukou merged 1 commit into
python-ldap:masterpython-ldap/python-ldap:masterfrom
mistotebe:slaptestmistotebe/python-ldap:slaptestCopy head branch name to clipboard
Sep 20, 2019
Merged

Use slapd -Tt instead of slaptest#282
encukou merged 1 commit into
python-ldap:masterpython-ldap/python-ldap:masterfrom
mistotebe:slaptestmistotebe/python-ldap:slaptestCopy head branch name to clipboard

Conversation

@mistotebe

Copy link
Copy Markdown
Contributor

If we point SBIN to $openldap_source/servers/slapd, libtool scripts will
munge argv[0] and slapd won't recognise it's slaptest we asked for. So
just request a slapd tool directly.

If we point SBIN to $openldap_source/servers/slapd, libtool scripts will
munge argv[0] and slapd won't recognise it's slaptest we asked for. So
just request a slapd tool directly.
@codecov

codecov Bot commented May 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #282 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #282      +/-   ##
=========================================
- Coverage    71.1%   71.1%   -0.01%     
=========================================
  Files          49      49              
  Lines        4818    4817       -1     
  Branches      812     812              
=========================================
- Hits         3426    3425       -1     
- Misses       1056    1057       +1     
+ Partials      336     335       -1
Impacted Files Coverage Δ
Lib/slapdtest/_slapdtest.py 85% <ø> (-0.06%) ⬇️
Lib/ldap/controls/deref.py 57.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9dc4...e921829. Read the comment docs.

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in favor!

@encukou encukou merged commit 532ffc0 into python-ldap:master Sep 20, 2019
@tiran tiran added this to the 3.3 milestone May 27, 2020
@mistotebe mistotebe mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.