Retain last two chars for children device_id#733
Merged
rytilahti merged 1 commit intoFeb 1, 2024
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:janitor/childdevs_scrubrytilahti/python-kasa:janitor/childdevs_scrubCopy head branch name to clipboard
Merged
Retain last two chars for children device_id#733rytilahti merged 1 commit intopython-kasa:masterpython-kasa/python-kasa:masterfrom rytilahti:janitor/childdevs_scrubrytilahti/python-kasa:janitor/childdevs_scrubCopy head branch name to clipboard
rytilahti merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:janitor/childdevs_scrubrytilahti/python-kasa:janitor/childdevs_scrubCopy head branch name to clipboard
Conversation
This was referenced Feb 1, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 87.96% 87.99% +0.02%
==========================================
Files 41 41
Lines 3632 3632
Branches 910 910
==========================================
+ Hits 3195 3196 +1
Misses 362 362
+ Partials 75 74 -1 ☔ View full report in Codecov by Sentry. |
bdraco
approved these changes
Feb 1, 2024
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Feb 2, 2024
[Full Changelog](python-kasa/python-kasa@0.6.2...0.6.2.1) **Fixed bugs:** - Avoid crashing on childdevice property accesses [\python-kasa#732](python-kasa#732) (@rytilahti) **Merged pull requests:** - Retain last two chars for children device\_id [\python-kasa#733](python-kasa#733) (@rytilahti) - Add TP15 fixture [\python-kasa#730](python-kasa#730) (@bdraco) - Add TP25 fixtures [\python-kasa#729](python-kasa#729) (@bdraco) - Various test code cleanups [\python-kasa#725](python-kasa#725) (@rytilahti) - Unignore F401 for tests [\python-kasa#724](python-kasa#724) (@rytilahti)
Merged
rytilahti
added a commit
that referenced
this pull request
Feb 2, 2024
[Full Changelog](0.6.2...0.6.2.1) **Fixed bugs:** - Avoid crashing on childdevice property accesses [\#732](#732) (@rytilahti) **Merged pull requests:** - Retain last two chars for children device\_id [\#733](#733) (@rytilahti) - Add TP15 fixture [\#730](#730) (@bdraco) - Add TP25 fixtures [\#729](#729) (@bdraco) - Various test code cleanups [\#725](#725) (@rytilahti) - Unignore F401 for tests [\#724](#724) (@rytilahti)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to retain child ids to be able to differentiate between them.
Also, scrub
original_device_id.