Query and initialize child components#731
Closed
rytilahti wants to merge 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/tapo_child_componentsrytilahti/python-kasa:fix/tapo_child_componentsCopy head branch name to clipboard
Closed
Query and initialize child components#731rytilahti wants to merge 1 commit intopython-kasa:masterpython-kasa/python-kasa:masterfrom rytilahti:fix/tapo_child_componentsrytilahti/python-kasa:fix/tapo_child_componentsCopy head branch name to clipboard
rytilahti wants to merge 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/tapo_child_componentsrytilahti/python-kasa:fix/tapo_child_componentsCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 87.96% 87.98% +0.01%
==========================================
Files 41 41
Lines 3632 3638 +6
Branches 910 911 +1
==========================================
+ Hits 3195 3201 +6
Misses 362 362
Partials 75 75 ☔ View full report in Codecov by Sentry. |
Member
Author
|
I think this can wait until we have module support. For Hass, we can fix this by initialising the variable inside tapodevice's init. |
Member
Author
|
I'll just create a new PR from the scratch, as there has been so many changes around the now-smartdevice, that it makes no sense to revive this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializes the list of available components for child devices.
Fixes the issue seen in homeassistant (#729), tests should be improved before this can be merged.