Do not close out the session on connection error#682
Closed
bdraco wants to merge 1 commit into
masterpython-kasa/python-kasa:masterfrom
no_close_connection_errorpython-kasa/python-kasa:no_close_connection_errorCopy head branch name to clipboard
Closed
Do not close out the session on connection error#682bdraco wants to merge 1 commit intomasterpython-kasa/python-kasa:masterfrom no_close_connection_errorpython-kasa/python-kasa:no_close_connection_errorCopy head branch name to clipboard
bdraco wants to merge 1 commit into
masterpython-kasa/python-kasa:masterfrom
no_close_connection_errorpython-kasa/python-kasa:no_close_connection_errorCopy head branch name to clipboard
Conversation
The P100s drop the connection after every request
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 86.96% 86.96% -0.01%
==========================================
Files 39 39
Lines 3506 3505 -1
Branches 894 894
==========================================
- Hits 3049 3048 -1
Misses 378 378
Partials 79 79 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Closing as covered by #689 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P100s drop the connection after every request