Add retries to protocol queries#65
Merged
kirichkov merged 3 commits intoMay 27, 2020
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:feature/add_retriesrytilahti/python-kasa:feature/add_retriesCopy head branch name to clipboard
Merged
Add retries to protocol queries#65kirichkov merged 3 commits intopython-kasa:masterpython-kasa/python-kasa:masterfrom rytilahti:feature/add_retriesrytilahti/python-kasa:feature/add_retriesCopy head branch name to clipboard
kirichkov merged 3 commits into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:feature/add_retriesrytilahti/python-kasa:feature/add_retriesCopy head branch name to clipboard
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Yes, I'll rebase this on top of the master after that cleanup PR gets merged :-) edit: rebase done |
f0cf2d3 to
3aac122
Compare
kirichkov
approved these changes
May 27, 2020
kirichkov
left a comment
Contributor
There was a problem hiding this comment.
Much cleaner now! Good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry logic to protocol class. Defaults to 3 re-tries, so up to 4 queries are automatically tried.
This is based on #63.
Fixes #38