Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make timeout configurable for cli#564

Merged
rytilahti merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:feat/cli_add_timeout_optionrytilahti/python-kasa:feat/cli_add_timeout_optionCopy head branch name to clipboard
Dec 4, 2023
Merged

Make timeout configurable for cli#564
rytilahti merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:feat/cli_add_timeout_optionrytilahti/python-kasa:feat/cli_add_timeout_optionCopy head branch name to clipboard

Conversation

@rytilahti
Copy link
Copy Markdown
Member

Exposes configurable timeouts implemented in #494 to the cli tool.

Fixes #310

@rytilahti rytilahti added the enhancement New feature or request label Dec 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfd1d6a) 75.75% compared to head (35c1d0b) 75.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   75.75%   75.76%           
=======================================
  Files          34       34           
  Lines        2875     2876    +1     
  Branches      750      751    +1     
=======================================
+ Hits         2178     2179    +1     
  Misses        640      640           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti merged commit 347cbfe into python-kasa:master Dec 4, 2023
@rytilahti rytilahti deleted the feat/cli_add_timeout_option branch December 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set timeout using command line parameters

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.