Update discover single to handle hostnames#539
Merged
rytilahti merged 1 commit intoNov 7, 2023
python-kasa:masterpython-kasa/python-kasa:masterfrom
sdb9696:do_discover_single_dnssdb9696/python-kasa:do_discover_single_dnsCopy head branch name to clipboard
Merged
Update discover single to handle hostnames#539rytilahti merged 1 commit intopython-kasa:masterpython-kasa/python-kasa:masterfrom sdb9696:do_discover_single_dnssdb9696/python-kasa:do_discover_single_dnsCopy head branch name to clipboard
rytilahti merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
sdb9696:do_discover_single_dnssdb9696/python-kasa:do_discover_single_dnsCopy head branch name to clipboard
Conversation
Codecov ReportAttention:
馃摙 Thoughts on this report? Let us know!. |
bdraco
reviewed
Nov 1, 2023
ec98015 to
15b5c85
Compare
rytilahti
requested changes
Nov 2, 2023
Member
rytilahti
left a comment
There was a problem hiding this comment.
Never realized that this wasn't already working as initializing device instances manually just worked(tm) 馃憤
15b5c85 to
9cf2e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at merged PR #528 I noticed some users were using hostnames to add their devices and the current discover_single will not work with hostnames. This PR does a simple DNS lookup using getaddrinfo if a hostname is used so that it can match to the datagram response ip.
According to the getaddrinfo docs dns lookup only happens if node parameter is a hostname: