Allow effect presets seen on light strips#440
Merged
rytilahti merged 4 commits intoApr 1, 2023
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/bulb_presets_optional_colorsrytilahti/python-kasa:fix/bulb_presets_optional_colorsCopy head branch name to clipboard
Merged
Allow effect presets seen on light strips#440rytilahti merged 4 commits intopython-kasa:masterpython-kasa/python-kasa:masterfrom rytilahti:fix/bulb_presets_optional_colorsrytilahti/python-kasa:fix/bulb_presets_optional_colorsCopy head branch name to clipboard
rytilahti merged 4 commits into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/bulb_presets_optional_colorsrytilahti/python-kasa:fix/bulb_presets_optional_colorsCopy head branch name to clipboard
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
=======================================
Coverage 79.80% 79.81%
=======================================
Files 25 25
Lines 1892 1897 +5
Branches 231 231
=======================================
+ Hits 1510 1514 +4
- Misses 342 343 +1
Partials 40 40
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Just to avoid potential problems if devices do not accept extra keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payloads differ on light strips depending on whether the preset is for an effect or for regular bulb settings.
Fixes #439