Add turnonbehaviormodule for iot#1288
Draft
rytilahti wants to merge 1 commit into
masterpython-kasa/python-kasa:masterfrom
feat/iotbulb_turnonbehaviorpython-kasa/python-kasa:feat/iotbulb_turnonbehaviorCopy head branch name to clipboard
Draft
Add turnonbehaviormodule for iot#1288rytilahti wants to merge 1 commit intomasterpython-kasa/python-kasa:masterfrom feat/iotbulb_turnonbehaviorpython-kasa/python-kasa:feat/iotbulb_turnonbehaviorCopy head branch name to clipboard
rytilahti wants to merge 1 commit into
masterpython-kasa/python-kasa:masterfrom
feat/iotbulb_turnonbehaviorpython-kasa/python-kasa:feat/iotbulb_turnonbehaviorCopy head branch name to clipboard
Conversation
dbefbe8 to
de8710b
Compare
rytilahti
commented
Nov 20, 2024
| self.add_module(Module.Time, Time(self, "smartlife.iot.common.timesetting")) | ||
| self.add_module( | ||
| Module.IotTurnOnBehavior, | ||
| TurnOnBehaviorModule(self, "smartlife.iot.smartbulb.lightingservice"), |
Member
Author
There was a problem hiding this comment.
Named as Module, as TurnOnBehavior is already taken by the model... We probably want to make a breaking change here, and rename the models to something else.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft PR used for testing #1285.