Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

uri_reference.is_valid() accepts invalid hostnames and out-of-range ports #138

Copy link
Copy link
@QuantumNovice

Description

@QuantumNovice
Issue body actions

The validator returns True for inputs that violate URI rules.

Examples:

In [15]:  uri_reference('google.com/path').is_valid()
Out[15]: True
In [27]:  uri_reference('http://example.com:99999/').is_valid()
Out[27]: True

Expected behavior:

The validator should reject missing schemes when a hostname is present
and should reject port values greater than 65535.

Actual behavior:

is_valid() returns True for both invalid inputs.

Steps to reproduce:

  1. Run the two example expressions in a Python REPL.
  2. Observe that both return True.

Environment:

Library version:
Python version: Python 3.10.14
OS: Windows

Fix? :

  • Add port range validation and treat bare hostnames with paths as invalid
  • unless explicitly allowed by the spec.
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.