Fix edge-case Protocol bug on Python 3.7#242
Merged
JelleZijlstra merged 2 commits intoJun 16, 2023
python:mainpython/typing_extensions:mainfrom
AlexWaygood:proto-subclass-bugAlexWaygood/typing_extensions:proto-subclass-bugCopy head branch name to clipboard
Merged
Fix edge-case Protocol bug on Python 3.7#242JelleZijlstra merged 2 commits intopython:mainpython/typing_extensions:mainfrom AlexWaygood:proto-subclass-bugAlexWaygood/typing_extensions:proto-subclass-bugCopy head branch name to clipboard
Protocol bug on Python 3.7#242JelleZijlstra merged 2 commits into
python:mainpython/typing_extensions:mainfrom
AlexWaygood:proto-subclass-bugAlexWaygood/typing_extensions:proto-subclass-bugCopy head branch name to clipboard
Conversation
AlexWaygood
commented
Jun 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line is buggy. As a result of the bug, several of the assertions added in python/cpython#105835 don't pass on Python 3.7:
typing_extensions/src/typing_extensions.py
Line 743 in bc9ce4f
It should be
But we can also rewrite the condition more elegantly using the new
is_protocolfunction, so that's what I've done in this PR.