Don't reimplement runtime_checkable on py38+#194
Merged
JelleZijlstra merged 10 commits intoJun 9, 2023
python:mainpython/typing_extensions:mainfrom
AlexWaygood:simplify-runtime-checkableAlexWaygood/typing_extensions:simplify-runtime-checkableCopy head branch name to clipboard
Merged
Don't reimplement runtime_checkable on py38+#194JelleZijlstra merged 10 commits intopython:mainpython/typing_extensions:mainfrom AlexWaygood:simplify-runtime-checkableAlexWaygood/typing_extensions:simplify-runtime-checkableCopy head branch name to clipboard
runtime_checkable on py38+#194JelleZijlstra merged 10 commits into
python:mainpython/typing_extensions:mainfrom
AlexWaygood:simplify-runtime-checkableAlexWaygood/typing_extensions:simplify-runtime-checkableCopy head branch name to clipboard
Conversation
JelleZijlstra
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-export it from
typinginstead.Prior to #184,
typing.runtime_checkabledidn't work ontyping_extensions.Protocol. Now thattyping_extensions.Protocolinherits fromtyping.Genericon py38+, however, it does! This means that we can just re-exporttyping.runtime_checkableon py38+, rather than reimplementing it on all versions <3.12.