Python2: fix groupindex and lastgroup for re#6778
Closed
jpy-git wants to merge 1 commit into
python:masterpython/typeshed:masterfrom
jpy-git:py2_re_groupindex_lastgroupjpy-git/typeshed:py2_re_groupindex_lastgroupCopy head branch name to clipboard
Closed
Python2: fix groupindex and lastgroup for re#6778jpy-git wants to merge 1 commit intopython:masterpython/typeshed:masterfrom jpy-git:py2_re_groupindex_lastgroupjpy-git/typeshed:py2_re_groupindex_lastgroupCopy head branch name to clipboard
jpy-git wants to merge 1 commit into
python:masterpython/typeshed:masterfrom
jpy-git:py2_re_groupindex_lastgroupjpy-git/typeshed:py2_re_groupindex_lastgroupCopy head branch name to clipboard
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
All of your tests use the same kind of string. In Python 2, What's your motivation for fixing anything in the Python 2 stubs? We will accept pull requests, but at least I personally don't really care about whether anyone fixes them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to #6776.
I checked these types for Python 2.7 as well and observed the same behaviour:
N.B. I also checked if #6763 also applies to Python 2 and observed that Nones are not produced so the current Python 2 typing for
re.Pattern.split()is correct.