Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add __note__ to BaseException in Python 3.11#6633

Merged
JelleZijlstra merged 1 commit into
python:masterpython/typeshed:masterfrom
lancelote:dunder-notelancelote/typeshed:dunder-noteCopy head branch name to clipboard
Dec 20, 2021
Merged

Add __note__ to BaseException in Python 3.11#6633
JelleZijlstra merged 1 commit into
python:masterpython/typeshed:masterfrom
lancelote:dunder-notelancelote/typeshed:dunder-noteCopy head branch name to clipboard

Conversation

@lancelote

Copy link
Copy Markdown
Contributor

@AlexWaygood

AlexWaygood commented Dec 20, 2021

Copy link
Copy Markdown
Member

It seems like the Steering Council hasn't formally signed off on this addition yet -- might it be worth waiting until the change is confirmed? python/peps#2201

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@lancelote

lancelote commented Dec 20, 2021

Copy link
Copy Markdown
Contributor Author

Ah, I see, thanks. The change is available in 3.11.0a3, so I thought it was already approved.

@JelleZijlstra

Copy link
Copy Markdown
Member

Since it's currently in 3.11, I say we put it in; it's easy to remove it later if the PEP gets rejected.

@JelleZijlstra JelleZijlstra merged commit b1b958d into python:master Dec 20, 2021
@lancelote lancelote deleted the dunder-note branch December 20, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.