PEP 544: correct comments on assignments to protocol-hinted targets#3010
Closed
chepner wants to merge 1 commit into
Closed
PEP 544: correct comments on assignments to protocol-hinted targets#3010chepner wants to merge 1 commit into
chepner wants to merge 1 commit into
Conversation
Fix comments on a pair of protocol-hinted assignment.
|
All commit authors signed the Contributor License Agreement. |
Member
|
The example is correct. See #2332. |
Member
|
Considering this keeps confusing people and getting reported/attempted to be changed, it might be worth adding a comment to explicitly clarify this and avoid future such reports/PRs, as discussed in #2332 |
Member
|
Yes, if someone will make a PR with a comment as discussed I will take a look. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix comments on a pair of protocol-hinted assignment.
PEP 123: Summary of changes)