Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...'#2809

Merged
hugovk merged 8 commits into
python:mainpython/peps:mainfrom
hugovk:fix-author-formathugovk/peps:fix-author-formatCopy head branch name to clipboard
Oct 5, 2022
Merged

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...'#2809
hugovk merged 8 commits into
python:mainpython/peps:mainfrom
hugovk:fix-author-formathugovk/peps:fix-author-formatCopy head branch name to clipboard

Conversation

@hugovk

@hugovk hugovk commented Oct 3, 2022

Copy link
Copy Markdown
Member

Prep for #2672.

  • Enable the validate-author check for .txt PEPs
  • Reformat the old email@example.com (Name) headers to Name <email@example.com>
  • Whilst editing those files, also remove the redundant emacs metadata
  • And fix the couple of footnote warnings in PEPs 3 and 231:
pep-0003.txt:72: WARNING: Footnote [1] is not referenced.
pep-0231.txt:616: WARNING: Footnote [8] is not referenced.

@hugovk hugovk force-pushed the fix-author-format branch from 6066814 to 42f5a07 Compare October 4, 2022 22:08
@hugovk hugovk requested a review from ncoghlan as a code owner October 4, 2022 22:08
@hugovk

hugovk commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

Updated with suggestions from CAM:

  • Infra: Remove redundant validate-author-legacy pre-commit check, now that validate-author runs for both rst and txt
  • PEP 1: Remove redundant sentence, now we only have the new author format
  • And whilst we're editing these files, also remove redundant Version and Last-Modified headers

@hugovk hugovk removed the request for review from ncoghlan October 4, 2022 22:15

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @hugovk !

@CAM-Gerlach CAM-Gerlach removed the bug label Oct 4, 2022
@hugovk hugovk merged commit 5fb8b28 into python:main Oct 5, 2022
@hugovk hugovk deleted the fix-author-format branch October 5, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.